[webkit-reviews] review granted: [Bug 53354] XSSFilter should log to the console when it blocks something : [Attachment 80524] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 53354: XSSFilter should log to the console when it blocks something
https://bugs.webkit.org/show_bug.cgi?id=53354

Attachment 80524: Patch
https://bugs.webkit.org/attachment.cgi?id=80524&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80524&action=review

How do we test this?

> Source/WebCore/html/parser/XSSFilter.cpp:151
> +	   return filterMetaToken(token) || didBlockScript;

I like the other |= format here, mostly because you used it everywhere else in
the file and it's nice to be consistent.  Then you wouldn't return after any of
these, just a long else if chain.