[webkit-reviews] review requested: [Bug 53353] build-webkit gives a bogus warning with newer versions of Xcode : [Attachment 80523] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 28 16:29:39 PST 2011


David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 53353: build-webkit gives a bogus warning with newer versions of Xcode
https://bugs.webkit.org/show_bug.cgi?id=53353

Attachment 80523: Patch
https://bugs.webkit.org/attachment.cgi?id=80523&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Reviewed by NOBODY (OOPS!).

* Scripts/webkitdirs.pm:
(checkRequiredSystemConfig): Check the Xcode marketing version
in addition to the DevCoreTools build version before complaining
about an old version of Xcode.	Also make the Mac OS X version
check use Perl's built-in version string comparitor.
---
 2 files changed, 19 insertions(+), 3 deletions(-)


More information about the webkit-reviews mailing list