[webkit-reviews] review denied: [Bug 53202] Async event handlers should not fire within a modal dialog : [Attachment 80494] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has denied Mihai Parparita
<mihaip at chromium.org>'s request for review:
Bug 53202: Async event handlers should not fire within a modal dialog
https://bugs.webkit.org/show_bug.cgi?id=53202

Attachment 80494: Patch
https://bugs.webkit.org/attachment.cgi?id=80494&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80494&action=review

> Source/WebCore/dom/Document.cpp:416
> +    , m_eventQueue(adoptPtr(new EventQueue(this)))

EventQueue should have a ::create() which returns a PassOwnPtr.  new should
pretty much never be outside of a ::create

> Source/WebCore/dom/EventQueue.cpp:38
> +class EventQueueTimer : public SuspendableTimer {

Is all of this just to avoid including SuspendableTimer.h in EventQueue.h?  If
so, I'm not sure it's worth it.

> Source/WebCore/dom/EventQueue.cpp:41
> +    explicit EventQueueTimer(EventQueue* eventQueue, ScriptExecutionContext*
context)

no explicit

> Source/WebCore/dom/EventQueue.h:52
> +    explicit EventQueue(ScriptExecutionContext*);

Make private and add a factory method

> Source/WebCore/dom/EventQueue.h:57
> +    

remove tab