[webkit-reviews] review granted: [Bug 15123] Self-replicating code makes Safari hang and eventually crash : [Attachment 80488] write recursion fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 28 13:56:22 PST 2011


Adam Barth <abarth at webkit.org> has granted chris reiss
<christopher.reiss at nokia.com>'s request for review:
Bug 15123: Self-replicating code makes Safari hang and eventually crash
https://bugs.webkit.org/show_bug.cgi?id=15123

Attachment 80488: write recursion fix
https://bugs.webkit.org/attachment.cgi?id=80488&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80488&action=review

Thanks for adding the extra tests!

> LayoutTests/fast/dom/Document/document-close-iframe-load.html:6
> +<!--iframe onload="document.open();document.close();" -->

Is there a reason this is commented out? This test doesn't seem like it tests
very much...

> LayoutTests/fast/dom/Document/document-close-iframe-load-expected.txt:2
> +ALERT: PASS (just to make expected.txt non-empty)
> +

I'm not sure how this expected file gets generated here.


More information about the webkit-reviews mailing list