[webkit-reviews] review denied: [Bug 53326] webkitpy: update fileset, zipfileset to be usable by rebaseline-chromium-webkit-tests : [Attachment 80486] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 53326: webkitpy: update fileset, zipfileset to be usable by
rebaseline-chromium-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=53326

Attachment 80486: Patch
https://bugs.webkit.org/attachment.cgi?id=80486&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80486&action=review

I think this needs a bit more testing, but in general looks good!  r- cause I'd
like to see at least one tst of the .sep support.

> Tools/Scripts/webkitpy/common/system/filesystem.py:206
> +	   """Returns the relative path from the starting point."""

This seems unhelpful.

> Tools/Scripts/webkitpy/common/system/filesystem_mock.py:56
> +	   idx = path.rfind(self.sep)

Seems we should test this new .sep support somewhere.

> Tools/Scripts/webkitpy/common/system/zipfileset.py:53
> +    def close(self):

Now that we have close, seems we might want to have __being__ __end__ support
(or whatever it takes to have "with" work).