[webkit-reviews] review granted: [Bug 53282] Downloads in WK2 on Windows should write resume data to bundle : [Attachment 80477] Patch v2

[bugzilla-daemon at webkit.org]

Alice Liu <alice.liu at apple.com> has granted Jon Honeycutt
<jhoneycutt at apple.com>'s request for review:
Bug 53282: Downloads in WK2 on Windows should write resume data to bundle
https://bugs.webkit.org/show_bug.cgi?id=53282

Attachment 80477: Patch v2
https://bugs.webkit.org/attachment.cgi?id=80477&action=review

------- Additional Comments from Alice Liu <alice.liu at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=80477&action=review

> Source/WebKit/win/WebDownloadCFNet.cpp:253
> +    resumeData.adoptCF(CFURLDownloadCopyResumeData(m_download.get()));

awesome

> Source/WebKit2/WebProcess/Downloads/cf/DownloadCFNet.cpp:171
> +}

do you need to null-check download?

> Source/WebKit2/WebProcess/Downloads/cf/DownloadCFNet.cpp:179
> +    download->didCreateDestination(download->destination());

do you need to null-check download?

> Source/WebKit2/WebProcess/Downloads/curl/DownloadCurl.cpp:58
> +}

if there's nothing that you know we need to do, you can leave this out. but if
we do need to do something, please comment at least briefly about it.

> Source/WebKit2/WebProcess/Downloads/mac/DownloadMac.mm:174
> +

presumably intentionally empty, and doesn't need notImplemented(), i assume.

> Source/WebKit2/WebProcess/Downloads/qt/DownloadQt.cpp:57
> +}

if there's nothing that you know we need to do, you can leave this out. but if
we do need to do something, please comment at least briefly about it.