[webkit-reviews] review granted: [Bug 53126] nrwt: add a "mock" DRT implementation for better testing of new-run-webkit-tests : [Attachment 80387] put the encoding/decoding of utf-8 where it should be, in filesystem_mock and MockDRT()

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 53126: nrwt: add a "mock" DRT implementation for better testing of
new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=53126

Attachment 80387: put the encoding/decoding of utf-8 where it should be, in
filesystem_mock and MockDRT()
https://bugs.webkit.org/attachment.cgi?id=80387&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80387&action=review

> Tools/Scripts/webkitpy/layout_tests/port/mock_drt.py:180
> +	   actual_text = port.expected_text(test_path).encode('utf-8')
> +	   if self._options.pixel_tests and expected_checksum:
> +	       actual_checksum =
port.expected_checksum(test_path).encode('utf-8')
> +	       actual_image = port.expected_image(test_path)

Nit: Rather than calling encode('utf-8') in lots of places, maybe there should
be a helper "write_text_file_data_to_stdout" that does the conversion.