[webkit-reviews] review granted: [Bug 36688] [Qt] LayoutTests/http/tests/appcache/auth.html failed and skipped : [Attachment 80449] fix patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Chang Shu <Chang.Shu at nokia.com>'s
request for review:
Bug 36688: [Qt] LayoutTests/http/tests/appcache/auth.html failed and skipped
https://bugs.webkit.org/show_bug.cgi?id=36688

Attachment 80449: fix patch
https://bugs.webkit.org/attachment.cgi?id=80449&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80449&action=review

r=me, with one adjustment:

> Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp:560
> +    if (isHttpTest(url)) {

The helper method is a bit misleading, I think we should simply inline the
check here, and also make it more specific, i.e:
if (url.scheme() == "http" || url.scheme() == "https")