[webkit-reviews] review granted: [Bug 30831] Web Inspector: syntax highlight inline JS and CSS in HTML resources : [Attachment 80436] [PATCH] Comment addressed, added STYLE check in 2 places

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 30831: Web Inspector: syntax highlight inline JS and CSS in HTML resources
https://bugs.webkit.org/show_bug.cgi?id=30831

Attachment 80436: [PATCH] Comment addressed, added STYLE check in 2 places
https://bugs.webkit.org/attachment.cgi?id=80436&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80436&action=review

> Source/WebCore/inspector/front-end/SourceHTMLTokenizer.re2js:268
>			   // Do not tokenize script tag contents, keep lexer
state although processing "<".

Please update the comment to reflect that you're skipping style tag content as
well.

> Source/WebCore/inspector/front-end/SourceHTMLTokenizer.re2js:322
> +		       if (this._condition.parseCondition ===
this._parseConditions.SCRIPT || this._condition.parseCondition ===
this._parseConditions.STYLE) {

We should be consistent in using === vs & if there is no difference in case of
SCRIPT and STYLE parse conditions I'd prefer ===