[webkit-reviews] review denied: [Bug 30831] Web Inspector: syntax highlight inline JS and CSS in HTML resources : [Attachment 80204] [PATCH] Suggested solution

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 28 02:24:01 PST 2011


Yury Semikhatsky <yurys at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 30831: Web Inspector: syntax highlight inline JS and CSS in HTML resources
https://bugs.webkit.org/show_bug.cgi?id=30831

Attachment 80204: [PATCH] Suggested solution
https://bugs.webkit.org/attachment.cgi?id=80204&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80204&action=review

> Source/WebCore/inspector/front-end/SourceHTMLTokenizer.re2js:267
>		       if (this._condition.parseCondition &
this._parseConditions.SCRIPT) {

You should add a check for STYLE state here, r- for this.


More information about the webkit-reviews mailing list