[webkit-reviews] review denied: [Bug 47264] Introduce the device element as an experimental feature : [Attachment 80411] Proposed patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Adam Bergkvist
<adam.bergkvist at ericsson.com>'s request for review:
Bug 47264: Introduce the device element as an experimental feature
https://bugs.webkit.org/show_bug.cgi?id=47264

Attachment 80411: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=80411&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80411&action=review

r- for build failures and changing the parser without adding a test.

> Source/WebCore/html/parser/HTMLTreeBuilder.cpp:897
> +#if ENABLE(DEVICE_ELEMENT)
> +	   || token.name() == deviceTag
> +#endif

HTML parsing should not be conditional on which features are enabled.  If this
line of could should be here, it should be here unconditionally and we should
have parser test that demonstrates this change.

> Source/WebCore/platform/device/StreamDeviceManager.cpp:38
> +#if 0

#if 0 ?