[webkit-reviews] review requested: [Bug 47264] Introduce the device element as an experimental feature : [Attachment 80411] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 27 20:31:10 PST 2011


Adam Bergkvist <adam.bergkvist at ericsson.com> has asked	for review:
Bug 47264: Introduce the device element as an experimental feature
https://bugs.webkit.org/show_bug.cgi?id=47264

Attachment 80411: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=80411&action=review

------- Additional Comments from Adam Bergkvist <adam.bergkvist at ericsson.com>
Implementation of the device element without any platform specific parts
(nothing added to the build systems). The patch contains a few lines of code
which has been commented out to show how it ties together with the Stream API
(see https://bugs.webkit.org/show_bug.cgi?id=47265). A proposed GTK
implementation is available as a patch to
https://bugs.webkit.org/show_bug.cgi?id=53264.



It's currently not possible to build without --device-element since the
bindings generator, regardless of feature guards, adds includes of
JSHTMLDeviceElement.h (in e.g. JSDOMWindow.cpp) which is not generated.


More information about the webkit-reviews mailing list