[webkit-reviews] review requested: [Bug 53281] clean up CG allocations made while determining image size : [Attachment 80406] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 27 20:01:35 PST 2011


Ian Henderson <ianh at apple.com> has asked  for review:
Bug 53281: clean up CG allocations made while determining image size
https://bugs.webkit.org/show_bug.cgi?id=53281

Attachment 80406: proposed patch
https://bugs.webkit.org/attachment.cgi?id=80406&action=review

------- Additional Comments from Ian Henderson <ianh at apple.com>
Proposed patch attached.  With the patch, loading the attached 1000-images uses
about 10 megabytes less memory.

1000-images in ToT r76862 (5 runs, vmmap -resident):
1-old.vmmap:Writable regions: Total=2.1G written=51.4M(2%) resident=75.5M(3%)
swapped_out=0K(0%) unallocated=2.1G(97%)
2-old.vmmap:Writable regions: Total=2.2G written=52.1M(2%) resident=76.2M(3%)
swapped_out=0K(0%) unallocated=2.1G(97%)
3-old.vmmap:Writable regions: Total=2.2G written=50.5M(2%) resident=74.6M(3%)
swapped_out=0K(0%) unallocated=2.1G(97%)
4-old.vmmap:Writable regions: Total=2.1G written=49.7M(2%) resident=73.8M(3%)
swapped_out=0K(0%) unallocated=2.1G(97%)
5-old.vmmap:Writable regions: Total=2.1G written=52.2M(2%) resident=76.3M(3%)
swapped_out=0K(0%) unallocated=2.1G(97%)

1000-images with 53281-1.patch applied (5 runs, vmmap -resident):
1-new.vmmap:Writable regions: Total=2.1G written=40.8M(2%) resident=64.9M(3%)
swapped_out=0K(0%) unallocated=2.1G(97%)
2-new.vmmap:Writable regions: Total=2.1G written=39.4M(2%) resident=63.5M(3%)
swapped_out=0K(0%) unallocated=2.1G(97%)
3-new.vmmap:Writable regions: Total=2.1G written=39.2M(2%) resident=63.3M(3%)
swapped_out=0K(0%) unallocated=2.1G(97%)
4-new.vmmap:Writable regions: Total=2.1G written=40.1M(2%) resident=64.3M(3%)
swapped_out=0K(0%) unallocated=2.1G(97%)
5-new.vmmap:Writable regions: Total=2.1G written=41.7M(2%) resident=65.8M(3%)
swapped_out=0K(0%) unallocated=2.1G(97%)


More information about the webkit-reviews mailing list