[webkit-reviews] review granted: [Bug 53277] Add basic rubber bandings support : [Attachment 80393] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 27 18:39:53 PST 2011


Maciej Stachowiak <mjs at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 53277: Add basic rubber bandings support
https://bugs.webkit.org/show_bug.cgi?id=53277

Attachment 80393: Patch
https://bugs.webkit.org/attachment.cgi?id=80393&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=80393&action=review

r=me with minor comments.

> Source/WebCore/ChangeLog:5
> +	   Add basic rubber bandings support

s/bandings/banding/

> Source/WebCore/page/EventHandler.cpp:2047
> +    // that if a frame gets a gesture begin gesture, it gets the
corrisponding

s/corrisponding/corresponding/

> Source/WebCore/platform/mac/ScrollAnimatorMac.h:44
> +#define SUPPORT_RUBBER_BANDING 1

This should probably be an ENABLE macro.


More information about the webkit-reviews mailing list