[webkit-reviews] review granted: [Bug 53263] contentEditable formatBlock crashes on divs with contenteditable="false" : [Attachment 80371] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Emil A Eklund <eae at chromium.org>'s
request for review:
Bug 53263: contentEditable formatBlock crashes on divs with
contenteditable="false"
https://bugs.webkit.org/show_bug.cgi?id=53263

Attachment 80371: Patch
https://bugs.webkit.org/attachment.cgi?id=80371&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=80371&action=review

>> Source/WebCore/editing/FormatBlockCommand.cpp:72
>> +	    return;
> 
> Why don’t other commands need this kind of check? Is this really specific to
FormatBlock?

I figured out the answer to my own question. The simple editing commands all
have code in them that checks and does nothing if the nodes involved are not
editable. And the complex commands are built out of the simple commands. So in
most cases, no checking is needed.

There may be some advantage to doing some higher level checking so we don’t end
up with undoable commands on the undo chain that work hard to do nothing.