[webkit-reviews] review granted: [Bug 52785] execCommand("Paste") doesn't work in WebKitTestRunner : [Attachment 80370] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Maciej Stachowiak <mjs at apple.com>'s
request for review:
Bug 52785: execCommand("Paste") doesn't work in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=52785

Attachment 80370: Patch
https://bugs.webkit.org/attachment.cgi?id=80370&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=80370&action=review

> Source/WebKit2/Shared/WebPreferencesStore.h:69
>      macro(AuthorAndUserStylesEnabled, authorAndUserStylesEnabled, Bool,
bool, true) \
>      macro(PaginateDuringLayoutEnabled, paginateDuringLayoutEnabled, Bool,
bool, false) \
>      macro(DOMPasteAllowed, domPasteAllowed, Bool, bool, false) \
> +    macro(JavaScriptCanAccessClipboard, javaScriptCanAccessClipboard, Bool,
bool, false) \
>      macro(ShouldPrintBackgrounds, shouldPrintBackgrounds, Bool, bool, false)
\

Can we keep this sorted alphabetically?

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1268
>     
settings->setAuthorAndUserStylesEnabled(store.getBoolValueForKey(WebPreferences
Key::authorAndUserStylesEnabledKey()));
>     
settings->setPaginateDuringLayoutEnabled(store.getBoolValueForKey(WebPreference
sKey::paginateDuringLayoutEnabledKey()));
>     
settings->setDOMPasteAllowed(store.getBoolValueForKey(WebPreferencesKey::domPas
teAllowedKey()));
> +   
settings->setJavaScriptCanAccessClipboard(store.getBoolValueForKey(WebPreferenc
esKey::javaScriptCanAccessClipboardKey()));
>     
settings->setShouldPrintBackgrounds(store.getBoolValueForKey(WebPreferencesKey:
:shouldPrintBackgroundsKey()));

Can we keep this sorted alphabetically?