[webkit-reviews] review granted: [Bug 53252] Split MediaControls out of RenderMedia. : [Attachment 80356] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 27 14:47:25 PST 2011
Eric Carlson <eric.carlson at apple.com> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 53252: Split MediaControls out of RenderMedia.
https://bugs.webkit.org/show_bug.cgi?id=53252
Attachment 80356: Patch
https://bugs.webkit.org/attachment.cgi?id=80356&action=review
------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
BRAVO!!
View in context: https://bugs.webkit.org/attachment.cgi?id=80356&action=review
> Source/WebCore/rendering/RenderMedia.cpp:-106
> -MediaPlayer* RenderMedia::player() const
> -{
> - return mediaElement()->player();
> -}
> -
Why did you delete this function and update the call sites to use
"mediaElement()->player()".
More information about the webkit-reviews
mailing list