[webkit-reviews] review granted: [Bug 52868] [chromium] Fix redundant video frame paint on CSS LayerChromium for <video> : [Attachment 80286] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Victoria Kirst
<vrk at chromium.org>'s request for review:
Bug 52868: [chromium] Fix redundant video frame paint on CSS LayerChromium for
<video>
https://bugs.webkit.org/show_bug.cgi?id=52868

Attachment 80286: Patch
https://bugs.webkit.org/attachment.cgi?id=80286&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80286&action=review

Seems good.  Could you please confirm that this code change is hit by existing
tests (at least some of the webgl ones) and that they still work with this
patch applied?

> Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp:-486
> -
> -#if USE(ACCELERATED_COMPOSITING)
> -    Frame* frame = static_cast<HTMLMediaElement*>(
> -	   client->m_mediaPlayer->mediaPlayerClient())->document()->frame();
> -
> -    // This does not actually check whether the hardware can support
accelerated
> -    // compositing, but only if the flag is set. However, this is checked
lazily
> -    // in WebViewImpl::setIsAcceleratedCompositingActive() and will fail
there
> -    // if necessary.
> -    client->m_supportsAcceleratedCompositing =
> -	   frame->contentRenderer()->compositor()->hasAcceleratedCompositing();

> -#endif

I don't understand this code move - is this part of the same patch?