[webkit-reviews] review denied: [Bug 53253] Move wince/mt19937ar.c to ThirdParty and make it a policy choice : [Attachment 80361] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 27 13:45:38 PST 2011
Patrick R. Gansterer <paroga at paroga.com> has denied Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 53253: Move wince/mt19937ar.c to ThirdParty and make it a policy choice
https://bugs.webkit.org/show_bug.cgi?id=53253
Attachment 80361: Patch
https://bugs.webkit.org/attachment.cgi?id=80361&action=review
------- Additional Comments from Patrick R. Gansterer <paroga at paroga.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=80361&action=review
> Source/JavaScriptCore/CMakeListsWinCE.txt:3
> +LIST(APPEND JavaScriptCore_INCLUDE_DIRECTORIES
> + "${CMAKE_SOURCE_DIR}/Source/ThirdParty"
> +)
${CMAKE_SOURCE_DIR} is already <root>/Source, so it should read
"${CMAKE_SOURCE_DIR}/ThirdParty"
I'll try this change on my local build, because I'm not sure if it's the
correct "*_INCLUDE_DIRECTORIES"
More information about the webkit-reviews
mailing list