[webkit-reviews] review granted: [Bug 52219] WebKit2 GTK Fails to Build #include nested too deeply : [Attachment 80349] Proposed patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Alejandro G. Castro
<alex at igalia.com>'s request for review:
Bug 52219: WebKit2 GTK Fails to Build #include nested too deeply
https://bugs.webkit.org/show_bug.cgi?id=52219

Attachment 80349: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=80349&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80349&action=review

Looks good with the removal of the no-longer-valid comment in configure.ac.

> configure.ac:-929
>      # In WebKit, this define is ensured by doing it before including
config.h in any source file.
>      # In WebKit2, WebKit2Prefix.h is included as first header file, so we
need to define this
>      # macro before actually WebKit2Prefix.h is included in any file.
> -    AC_DEFINE([__STDC_FORMAT_MACROS],[1],[Turn on the __STDC_FORMAT_MACROS
used in inttypes.h])

We probably need to remove the comment here as well.