[webkit-reviews] review granted: [Bug 53251] CACFLayerTreeHost should use WKCACFView for rendering : [Attachment 80351] Split CACFLayerTreeHost into base and derived classes

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Adam Roben (aroben)
<aroben at apple.com>'s request for review:
Bug 53251: CACFLayerTreeHost should use WKCACFView for rendering
https://bugs.webkit.org/show_bug.cgi?id=53251

Attachment 80351: Split CACFLayerTreeHost into base and derived classes
https://bugs.webkit.org/attachment.cgi?id=80351&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=80351&action=review

> Source/WebCore/platform/graphics/ca/win/CACFLayerTreeHost.cpp:213
> +    bool m_mightBeAbleToCreateDeviceLater;
> +    COMPtr<IDirect3DDevice9> m_d3dDevice;
> +    WKCACFContext* m_context;
> +    Timer<LegacyCACFLayerTreeHost> m_renderTimer;
> +    bool m_mustResetLostDeviceBeforeRendering;

Can you sort these to optimize padding?

> Source/WebCore/platform/graphics/ca/win/CACFLayerTreeHost.h:98
>      CACFLayerTreeHostClient* m_client;
> -    bool m_mightBeAbleToCreateDeviceLater;
> -    COMPtr<IDirect3DDevice9> m_d3dDevice;
>      RefPtr<PlatformCALayer> m_rootLayer;
>      RefPtr<PlatformCALayer> m_rootChildLayer;
> -    WKCACFContext* m_context;
>      HWND m_window;
> -    Timer<CACFLayerTreeHost> m_renderTimer;
> -    bool m_mustResetLostDeviceBeforeRendering;
>      bool m_shouldFlushPendingGraphicsLayerChanges;
>      bool m_isFlushingLayerChanges;
>      HashSet<RefPtr<PlatformCALayer> > m_pendingAnimatedLayers;

Ditto.