[webkit-reviews] review requested: [Bug 53235] Web Inspector: new api for managing JavaScript breakpoints : [Attachment 80325] Patch.

[bugzilla-daemon at webkit.org]

Pavel Podivilov <podivilov at chromium.org> has asked  for review:
Bug 53235: Web Inspector: new api for managing JavaScript breakpoints
https://bugs.webkit.org/show_bug.cgi?id=53235

Attachment 80325: Patch.
https://bugs.webkit.org/attachment.cgi?id=80325&action=review

------- Additional Comments from Pavel Podivilov <podivilov at chromium.org>
Single protocol breakpoint (e.g. set by url) is mapped on zero or more VM
breakpoints (set by sourceID).
removeJavaScriptBreakpoint(breakpointId) removes breakpoint and all linked VM
breakpoints.
Since UI uses VM breakpoint location rather then protocol breakpoint location,
all resolved breakpoints locations are passed to frontend.

SourceFrame is now aware of whether breakpoint is resolved or not and may
display it accordingly.
JavaScriptBreakpointsSidebarPane filters out breakpoints set on nonexistent
scripts to avoid UI cluttering.