[webkit-reviews] review denied: [Bug 53171] Web Inspector: [Elements panel] Tooltip for relative links incorrectly identifies current URL : [Attachment 80313] [PATCH] Suggested fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 27 04:05:11 PST 2011


Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 53171: Web Inspector: [Elements panel] Tooltip for relative links
incorrectly identifies current URL
https://bugs.webkit.org/show_bug.cgi?id=53171

Attachment 80313: [PATCH] Suggested fix
https://bugs.webkit.org/attachment.cgi?id=80313&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80313&action=review

> Source/WebCore/inspector/front-end/inspector.js:1518
> +	       // A href of "?foo=bar" implies "basePath?foo=bar".

Can we get a test for it? Should simply dump a number of
WebInspector.completeURL invocations. Otherwise looks good.


More information about the webkit-reviews mailing list