[webkit-reviews] review denied: [Bug 52791] Buffer overrun in WebCore::InspectorBasicValue::writeJSON : [Attachment 80312] Updated patch (hopefully final)

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Mikołaj Małecki
<m.malecki at samsung.com>'s request for review:
Bug 52791: Buffer overrun in WebCore::InspectorBasicValue::writeJSON
https://bugs.webkit.org/show_bug.cgi?id=52791

Attachment 80312: Updated patch (hopefully final)
https://bugs.webkit.org/attachment.cgi?id=80312&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80312&action=review

One last thing!

> WebCore/ChangeLog:6
> +

Please add a link to this bug under this line.

> WebCore/ChangeLog:7
> +	   No new tests. The problem can be reproduced by trying to create
InspectorValue

Nit: I think you could add a console.log("Large value %d", 1E10000) or similar
into
http://codesearch.google.com/codesearch/p?hl=en#OAMlx_jo-ck/src/third_party/Web
Kit/LayoutTests/inspector/console-format.html&q=LayoutTests/inspector/console&e
xact_package=chromium&l=12 and do run-webkit-tests --debug
inspector/console-format.hmtl. That would cover our work!