[webkit-reviews] review granted: [Bug 52984] SVG animation of Paths with segments of different coordinate modes on begin and end : [Attachment 80113] Patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Dirk Schulze
<krit at webkit.org>'s request for review:
Bug 52984: SVG animation of Paths with segments of different coordinate modes
on begin and end
https://bugs.webkit.org/show_bug.cgi?id=52984

Attachment 80113: Patch
https://bugs.webkit.org/attachment.cgi?id=80113&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80113&action=review

r=me.

>> Source/WebCore/svg/SVGPathBlender.cpp:273
>> +	return to == from - 1;
> 
> I don't get this part, I need to recheck.

I orignally proposed:

    if (isAbsoluteCommand(from))
	return from == to - !isAbsoluteCommand(to);
     return from - isAbsoluteCommand(to) == to;

if from is absolute, then from == to (if to is absolute) OR from == to - 1 (if
to is relative).
If from is relative, then from == to (if to is relative) OR from -1 == to (if
to is absolute).

I see that your if (fromMode == toMode) covers the case when boths modes are
either abs or relative, that is correct.
iAh, just realized the code is identical :-) good work.