[webkit-reviews] review requested: [Bug 50621] Implement text-combine rendering code : [Attachment 80294] Another new patch with Dave's input

[bugzilla-daemon at webkit.org]

Takumi Takano <takano at apple.com> has asked  for review:
Bug 50621: Implement text-combine rendering code
https://bugs.webkit.org/show_bug.cgi?id=50621

Attachment 80294: Another new patch with Dave's input
https://bugs.webkit.org/attachment.cgi?id=80294&action=review

------- Additional Comments from Takumi Takano <takano at apple.com>
Correct, RenderCombineText::widthFromCache was never invoked. My bad... When I
made things correct, I noticed widthFromCache is called before
RenderCombineText::prepareTextCombine is called. I added prepareTextCombine
call in RenderBlock::computeInlinePreferredLogicalWidths() as well. Also I
added a float:right block that contains combined text in my test html.