[webkit-reviews] review requested: [Bug 53024] It is needlessly expensive to find the generating node from an anonymous renderer of a pseudoelement. : [Attachment 80288] Proposed Patch

[bugzilla-daemon at webkit.org]

Carol Szabo <carol.szabo at nokia.com> has asked  for review:
Bug 53024: It is needlessly expensive to find the generating node from an
anonymous renderer of a pseudoelement.
https://bugs.webkit.org/show_bug.cgi?id=53024

Attachment 80288: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=80288&action=review

------- Additional Comments from Carol Szabo <carol.szabo at nokia.com>
Refactored beforeAfterContainer (which was not a member of
RenderObjectChildren, that is why it needed to go back to RenderObject to find
the RenderObjectChildrenList).
Renamed `before` and `after` methods to beforePseudoElementRenderer and
afterPseudoElementRenderer respectively. Did not like `Container`, because the
returned renderer does not contain the PseudoElement it is either the
pseudoelement or its renderer depending on interpretation of what a
pseudoelement is. I was always confused by the prior nomenclature thinking that
the returned Renderer contains the before and the after pseudoelements'
renderers.