[webkit-reviews] review granted: [Bug 53217] new-run-webkit-tests: turn off pixel tests correctly by default for webkit-based ports : [Attachment 80285] fix so that you can still manually enable pixel tests
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 26 18:21:40 PST 2011
Mihai Parparita <mihaip at chromium.org> has granted Dirk Pranke
<dpranke at chromium.org>'s request for review:
Bug 53217: new-run-webkit-tests: turn off pixel tests correctly by default for
webkit-based ports
https://bugs.webkit.org/show_bug.cgi?id=53217
Attachment 80285: fix so that you can still manually enable pixel tests
https://bugs.webkit.org/attachment.cgi?id=80285&action=review
------- Additional Comments from Mihai Parparita <mihaip at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80285&action=review
> Tools/Scripts/webkitpy/layout_tests/port/webkit.py:60
> + if not hasattr(self._options, "pixel_tests") or
self._options.pixel_tests == None:
I think the condition "not get_option('pixel_tests')" should result in the same
behavior.
More information about the webkit-reviews
mailing list