[webkit-reviews] review denied: [Bug 52058] setContentEditable with true/false/inherit string is not working properly : [Attachment 80246] fix patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Chang Shu <Chang.Shu at nokia.com>'s
request for review:
Bug 52058: setContentEditable with true/false/inherit string is not working
properly
https://bugs.webkit.org/show_bug.cgi?id=52058

Attachment 80246: fix patch
https://bugs.webkit.org/attachment.cgi?id=80246&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=80246&action=review

> Source/WebCore/html/HTMLElement.cpp:743
> +    document()->updateLayoutIgnorePendingStylesheets();

This is wrong. The correct place to put a layout update is in the getter, not
the setter. If you make a test case that sets the attribute with setAttribute
or removeAttribute you will see that the fix is not effective for that case.