[webkit-reviews] review granted: [Bug 53190] Change the rest of HTMLMediaElement shadow DOM parts to use shadowPseudoId. : [Attachment 80228] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 26 16:44:54 PST 2011


Darin Adler <darin at apple.com> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 53190: Change the rest of HTMLMediaElement shadow DOM parts to use
shadowPseudoId.
https://bugs.webkit.org/show_bug.cgi?id=53190

Attachment 80228: Patch
https://bugs.webkit.org/attachment.cgi?id=80228&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=80228&action=review

> Source/WebCore/rendering/MediaControlElements.cpp:96
> +	   RefPtr<RenderStyle> timelineContainerStyle =
document()->styleSelector()->styleForElement(this, 0, true);
>	   renderer()->setStyle(timelineContainerStyle);

You should release the style to avoid a tiny bit of reference count churn or
not use the local variable at all here.


More information about the webkit-reviews mailing list