[webkit-reviews] review requested: [Bug 52058] setContentEditable with true/false/inherit string is not working properly : [Attachment 80246] fix patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 26 15:24:15 PST 2011


Chang Shu <Chang.Shu at nokia.com> has asked  for review:
Bug 52058: setContentEditable with true/false/inherit string is not working
properly
https://bugs.webkit.org/show_bug.cgi?id=52058

Attachment 80246: fix patch
https://bugs.webkit.org/attachment.cgi?id=80246&action=review

------- Additional Comments from Chang Shu <Chang.Shu at nokia.com>
As we have discussed, calling
document()->updateLayoutIgnorePendingStylesheets() in setContentEditable() is
not the ultimate solution for resolving the dom-renderstyle sync problem as
setAttribute("contenteditable",value) will still fail. But at least, the
"contentEditable = value" case is resolved and it won't cause a big performance
regression. So I put this patch for review.


More information about the webkit-reviews mailing list