[webkit-reviews] review denied: [Bug 52833] shaderSource needs to preserve original source : [Attachment 80232] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied Zhenyao Mo <zmo at google.com>'s
request for review:
Bug 52833: shaderSource needs to preserve original source
https://bugs.webkit.org/show_bug.cgi?id=52833

Attachment 80232: Patch
https://bugs.webkit.org/attachment.cgi?id=80232&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=80232&action=review

> Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:1220
> +	   ASSERT_NOT_REACHED();

WebGLRenderingContext isn't the only client of this code; for example, the
accelerated 2D canvas code may go through it, and Chromium's accelerated
compositor is built on top of GraphicsContext3D. Please restore this
functionality. The required (slightly redundant) caches are negligible as
shaders are tiny.

I don't think any changes are needed in the Chromium port either. We really
just need the additional caching to preserve any Unicode characters in comments
for WebGL content.

> Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:1257
> +    ASSERT_NOT_REACHED();

Same here.