[webkit-reviews] review canceled: [Bug 53185] [chromium] revert r68310 because of race conditions detected by tsans : [Attachment 80221] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has canceled Tony Chang <tony at chromium.org>'s
request for review:
Bug 53185: [chromium] revert r68310 because of race conditions detected by
tsans
https://bugs.webkit.org/show_bug.cgi?id=53185

Attachment 80221: Patch
https://bugs.webkit.org/attachment.cgi?id=80221&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
Fails to link:


  LINK(target) out/Release/DumpRenderTree
out/Release/obj.target/third_party/WebKit/Source/WebCore/WebCore.gyp/libwebcore
_platform.a(SQLiteFileSystemChromiumPosix.o): In function `(anonymous
namespace)::chromiumOpen(sqlite3_vfs*, char const*, sqlite3_file*, int, int*)':

SQLiteFileSystemChromiumPosix.cpp:(.text._ZN118_GLOBAL__N_third_party_WebKit_So
urce_WebCore_platform_sql_chromium_SQLiteFileSystemChromiumPosix.cpp_00000000_D
C8A7F2712chromiumOpenEP11sqlite3_vfsPKcP12sqlite3_fileiPi+0x13): undefined
reference to `chromium_sqlite3_initialize_unix_sqlite3_file'
SQLiteFileSystemChromiumPosix.cpp:(.text._ZN118_GLOBAL__N_third_party_WebKit_So
urce_WebCore_platform_sql_chromium_SQLiteFileSystemChromiumPosix.cpp_00000000_D
C8A7F2712chromiumOpenEP11sqlite3_vfsPKcP12sqlite3_fileiPi+0x34): undefined
reference to `chromium_sqlite3_get_reusable_file_handle'
SQLiteFileSystemChromiumPosix.cpp:(.text._ZN118_GLOBAL__N_third_party_WebKit_So
urce_WebCore_platform_sql_chromium_SQLiteFileSystemChromiumPosix.cpp_00000000_D
C8A7F2712chromiumOpenEP11sqlite3_vfsPKcP12sqlite3_fileiPi+0x68): undefined
reference to `chromium_sqlite3_update_reusable_file_handle'
SQLiteFileSystemChromiumPosix.cpp:(.text._ZN118_GLOBAL__N_third_party_WebKit_So
urce_WebCore_platform_sql_chromium_SQLiteFileSystemChromiumPosix.cpp_00000000_D
C8A7F2712chromiumOpenEP11sqlite3_vfsPKcP12sqlite3_fileiPi+0xcf): undefined
reference to `chromium_sqlite3_fill_in_unix_sqlite3_file'
SQLiteFileSystemChromiumPosix.cpp:(.text._ZN118_GLOBAL__N_third_party_WebKit_So
urce_WebCore_platform_sql_chromium_SQLiteFileSystemChromiumPosix.cpp_00000000_D
C8A7F2712chromiumOpenEP11sqlite3_vfsPKcP12sqlite3_fileiPi+0xe7): undefined
reference to `chromium_sqlite3_destroy_reusable_file_handle'
SQLiteFileSystemChromiumPosix.cpp:(.text._ZN118_GLOBAL__N_third_party_WebKit_So
urce_WebCore_platform_sql_chromium_SQLiteFileSystemChromiumPosix.cpp_00000000_D
C8A7F2712chromiumOpenEP11sqlite3_vfsPKcP12sqlite3_fileiPi+0x140): undefined
reference to `chromium_sqlite3_destroy_reusable_file_handle'
collect2: ld returned 1 exit status
make: *** [out/Release/DumpRenderTree] Error 1