[webkit-reviews] review granted: [Bug 52873] Chromium DRT should provide command-line option for specifying timeout to ease debugging : [Attachment 80169] Updated patch: --no-timeout

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Xianzhu Wang
<wangxianzhu at google.com>'s request for review:
Bug 52873: Chromium DRT should provide command-line option for specifying
timeout to ease debugging
https://bugs.webkit.org/show_bug.cgi?id=52873

Attachment 80169: Updated patch: --no-timeout
https://bugs.webkit.org/attachment.cgi?id=80169&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80169&action=review

At some point, we should see if we can get Chromium DRT to do the same as Mac
DRT and call notifyDone on timeout.

> Tools/DumpRenderTree/chromium/DumpRenderTree.cpp:191
> +	       // 0x20000000ms is big enough for the purpose to avoid timeout
in debugging.
> +	       shell.setLayoutTestTimeout(0x20000000);

Why did you decide against INT_MAX from climits?