[webkit-reviews] review granted: [Bug 53174] Web Inspector: store all settings related to the agents on the frontend side : [Attachment 80199] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 53174: Web Inspector: store all settings related to the agents on the
frontend side
https://bugs.webkit.org/show_bug.cgi?id=53174

Attachment 80199: Patch
https://bugs.webkit.org/attachment.cgi?id=80199&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80199&action=review

> Source/WebCore/inspector/InspectorAgent.cpp:569
> +    if (InspectorDebuggerAgent::isDebuggerAlwaysEnabled() ||
m_state->getBoolean(InspectorState::debuggerEnabled))

I think InspectorDebuggerAgent::isDebuggerAlwaysEnabled should also be driven
by the front-end. As a result, state will have plane cookie logic.

> Source/WebCore/inspector/InspectorAgent.cpp:579
> +    if (!ScriptProfiler::isProfilerAlwaysEnabled() &&
m_state->getBoolean(InspectorState::profilerEnabled))

ditto

> Source/WebCore/inspector/InspectorAgent.cpp:981
> +void InspectorAgent::enableProfiler()

When did we lose skipRecompile?