[webkit-reviews] review denied: [Bug 53160] HTMLInputElement::setValue() should schedule change event when the element is focused : [Attachment 80173] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 26 06:59:17 PST 2011


Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Ilya Sherman
<isherman at chromium.org>'s request for review:
Bug 53160: HTMLInputElement::setValue() should schedule change event when the
element is focused
https://bugs.webkit.org/show_bug.cgi?id=53160

Attachment 80173: Patch
https://bugs.webkit.org/attachment.cgi?id=80173&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80173&action=review

> Source/WebCore/ChangeLog:9
> +	   No new tests. (OOPS!)

Please explain why no test is possible here.

> Source/WebCore/html/HTMLInputElement.cpp:897
> +	    
toRenderTextControl(renderer())->setChangedSinceLastChangeEvent(true);

Would it be possible for renderer() to be not RenderTextControl here?


More information about the webkit-reviews mailing list