[webkit-reviews] review denied: [Bug 52839] [Qt][Symbian] Fix --minimal build : [Attachment 80123] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 26 06:03:47 PST 2011


Laszlo Gombos <laszlo.1.gombos at nokia.com> has denied Yael
<yael.aharon at nokia.com>'s request for review:
Bug 52839: [Qt][Symbian] Fix --minimal build
https://bugs.webkit.org/show_bug.cgi?id=52839

Attachment 80123: Patch
https://bugs.webkit.org/attachment.cgi?id=80123&action=review

------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=80123&action=review

r- to fix the guard, otherwise looks good.

> Source/JavaScriptCore/wtf/Platform.h:834
> +#if !(PLATFORM(UNIX) || OS(SYMBIAN))

I think this should be "!PLATFORM(UNIX) || OS(SYMBIAN)" - the test above is
false for Symbian.


More information about the webkit-reviews mailing list