[webkit-reviews] review denied: [Bug 53167] Web Inspector: [Chromium] Incorrect JavaScript exception throw with wrong line number for invalid on* attribute. : [Attachment 80184] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 26 04:58:09 PST 2011


Pavel Feldman <pfeldman at chromium.org> has denied Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 53167: Web Inspector: [Chromium]  Incorrect JavaScript exception throw with
wrong line number for invalid on* attribute.
https://bugs.webkit.org/show_bug.cgi?id=53167

Attachment 80184: Patch
https://bugs.webkit.org/attachment.cgi?id=80184&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
Putting reviewer hat on now... We should not parse snippet twice. Probably we
could do some line number math based on the wrapper structure.


More information about the webkit-reviews mailing list