[webkit-reviews] review granted: [Bug 53072] Web Inspector: evaluate in console may not work when window.console is substituted : [Attachment 80176] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 26 02:16:58 PST 2011


Pavel Feldman <pfeldman at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 53072: Web Inspector: evaluate in console may not work when window.console
is substituted
https://bugs.webkit.org/show_bug.cgi?id=53072

Attachment 80176: Patch.
https://bugs.webkit.org/attachment.cgi?id=80176&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80176&action=review

> Source/WebCore/inspector/InjectedScriptSource.js:257
> +	       inspectedWindow.console._commandLineAPI = this._commandLineAPI;

Nit: defining non-enumerable property would be even better.


More information about the webkit-reviews mailing list