[webkit-reviews] review denied: [Bug 52422] [chromium] More crash in FontFallbackList::determinePitch(const Font* font) : [Attachment 80034] A carpet-bomb approach 2

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Hironori Bono
<hbono at chromium.org>'s request for review:
Bug 52422: [chromium] More crash in FontFallbackList::determinePitch(const
Font* font)
https://bugs.webkit.org/show_bug.cgi?id=52422

Attachment 80034: A carpet-bomb approach 2
https://bugs.webkit.org/attachment.cgi?id=80034&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80034&action=review

I think the change is reasonable.
r- because of a style error.

> Source/WebCore/platform/graphics/chromium/FontCacheChromiumWin.cpp:419
> +    OutputDebugString(logFont->lfFaceName);

Is this needed?

> Source/WebCore/platform/graphics/chromium/FontCacheChromiumWin.cpp:587
> +    if (dc) {
> +	 GetLastResortFallbackFontProcData procData(this, &description,
fallbackFontName);
> +	 EnumFontFamilies(dc, 0, getLastResortFallbackFontProc,
reinterpret_cast<LPARAM>(&procData));
> +	 ReleaseDC(0, dc);
> +
> +	 if (procData.m_fontData)
> +	   return procData.m_fontData;
> +    }

Wrong indentation.