[webkit-reviews] review granted: [Bug 53143] Add IntRectHash : [Attachment 80145] proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 53143: Add IntRectHash
https://bugs.webkit.org/show_bug.cgi?id=53143

Attachment 80145: proposed patch
https://bugs.webkit.org/attachment.cgi?id=80145&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=80145&action=review

>> Source/WebCore/platform/graphics/IntRectHash.h:30
>> +#include "IntPointHash.h"
> 
> Alphabetical sorting problem.  [build/include_order] [4]

I agree with the style bot.

>> Source/WebCore/platform/graphics/IntRectHash.h:37
>> +	template<> struct IntHash<WebCore::IntRect> {
> 
> Code inside a namespace should not be indented.  [whitespace/indent] [4]

I agree with the style bot.

>> Source/WebCore/platform/graphics/IntRectHash.h:48
>> +	template<> struct DefaultHash<WebCore::IntRect> { typedef
IntHash<WebCore::IntRect> Hash; };
> 
> More than one command on the same line  [whitespace/newline] [4]

This is a false positive from the style bot.

>> Source/WebCore/platform/graphics/IntSizeHash.h:29
>> +	template<> struct IntHash<WebCore::IntSize> {
> 
> Code inside a namespace should not be indented.  [whitespace/indent] [4]

I agree with the style bot, but I’m not sure we should re-indent the whole
file.

>> Source/WebCore/platform/graphics/IntSizeHash.h:34
>> +	template<> struct DefaultHash<WebCore::IntSize> { typedef
IntHash<WebCore::IntSize> Hash; };
> 
> More than one command on the same line  [whitespace/newline] [4]

False positive from the style bot.