[webkit-reviews] review denied: [Bug 52839] [Qt][Symbian] Fix --minimal build : [Attachment 80081] Patch

[bugzilla-daemon at webkit.org]

Laszlo Gombos <laszlo.1.gombos at nokia.com> has denied Yael
<yael.aharon at nokia.com>'s request for review:
Bug 52839: [Qt][Symbian] Fix --minimal build
https://bugs.webkit.org/show_bug.cgi?id=52839

Attachment 80081: Patch
https://bugs.webkit.org/attachment.cgi?id=80081&action=review

------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=80081&action=review

r- to fix the Windows build.

> Source/JavaScriptCore/wtf/Platform.h:786
> +

This would only set USE_SYSTEM_MALLOC for the Symbian port and would break for
example the Windows port of QtWebKit. I suggest we repeat the original rule
from WebKit.pri. 

We already have a section for setting memory management related defaults for
the Qt port, so perhaps we can add this rule there.

 #if PLATFORM(QT)
 /* We must not customize the global operator new and delete for the Qt port.
*/
 #define ENABLE_GLOBAL_FASTMALLOC_NEW 0
+#if !PLATFORM(UNIX) || OS(SYMBIAN)
+#define USE_SYSTEM_MALLOC 1
+#endif
 #endif

> Source/JavaScriptCore/wtf/TCSystemAlloc.cpp:34
> +#if !(defined(USE_SYSTEM_MALLOC) && USE_SYSTEM_MALLOC)

Can we just use !USE(SYSTEM_MALLOC) instead ?

> Source/JavaScriptCore/wtf/wtf.pri:45
> +SOURCES += wtf/TCSystemAlloc.cpp

I think we should move this entry together with the rest of the SOURCES list -
alphabetically ordered.