[webkit-reviews] review granted: [Bug 53036] nrwt: clean up unit tests, add test-mac, test-win, port.unit_test_user() : [Attachment 79972] update w/ review feedback from eric

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 53036: nrwt: clean up unit tests, add test-mac, test-win,
port.unit_test_user()
https://bugs.webkit.org/show_bug.cgi?id=53036

Attachment 79972: update w/ review feedback from eric
https://bugs.webkit.org/attachment.cgi?id=79972&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
(In reply to comment #13)
> (In reply to comment #12)
> > (From update of attachment 79972 [details] [details])
> > Seems OK.  Tony had some useful-to-fix-comments.
> 
> Apart from the src->source change, were any of the others things you think
should be changed in this patch before it lands (as opposed to later patches)?

Follow up patches are fine.  I prefer not returning tuples because it's fragile
and often hard to read.  It also makes it easy to grow the tuple, making things
harder to follow.

I much prefer just returning a class with named members because declaring
classes is so light weight compared to other languages.