[webkit-reviews] review granted: [Bug 53100] WK2 leaks when a page is closed : [Attachment 80088] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 53100: WK2 leaks when a page is closed
https://bugs.webkit.org/show_bug.cgi?id=53100

Attachment 80088: Patch
https://bugs.webkit.org/attachment.cgi?id=80088&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=80088&action=review

Please don’t break the Qt build, otherwise looks good.

> Source/WebKit2/UIProcess/API/mac/WKView.mm:1405
> +   
WKAXInitializeRemoteElementWithWindow(_data->_remoteAccessibilityChild.get(),
nil);

The use of initialize in the name of this function makes it surprising that you
can use it to clear the window. Perhaps it should be called
WKAXSetWindowForRemoteElement?

> Source/WebKit2/UIProcess/win/WebView.cpp:631
> +void WebView::pageClosed()
> +{
> +}

I think you’ll need this for Qt too, in UIProcess/API/qt/qwkpage.cpp.