[webkit-reviews] review denied: [Bug 52886] Web Inspector: size is wrong for cached resources in Network panel : [Attachment 80075] patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 52886: Web Inspector: size is wrong for cached resources in Network panel
https://bugs.webkit.org/show_bug.cgi?id=52886

Attachment 80075: patch
https://bugs.webkit.org/attachment.cgi?id=80075&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=80075&action=review

> Source/WebCore/inspector/Inspector.idl:110
> +	   [notify, domain=Network] void didReceiveResponse(out long
identifier, out double time, out String resourceType, out long cachedSize, out
Object response);

didReceiveResponse should not special-case cached resources. It would be better
to call didReceiveContentLength for cached resources instead.

> Source/WebCore/inspector/front-end/NetworkManager.js:179
> +	   if (resource.revalidated)

This would go away.

> Source/WebCore/inspector/front-end/Resource.js:241
> +	   var size = this.cached || this.revalidated ? 0 :
Number(this.resourceSize || this.responseHeaders["Content-Length"] || 0);

Could you replace ternary operators with guards for ease of understanding?

> Source/WebCore/inspector/front-end/Resource.js:309
> +    get revalidated()

get statusIsNotModified?