[webkit-reviews] review denied: [Bug 52876] Chromium DRT should clear page between tests like what Mac DRT does : [Attachment 80052] new patch that clears page between tests.

Tue Jan 25 09:42:24 PST 2011

Tony Chang <tony at chromium.org> has denied Xianzhu Wang
<wangxianzhu at google.com>'s request for review:
Bug 52876: Chromium DRT should clear page between tests like what Mac DRT does
https://bugs.webkit.org/show_bug.cgi?id=52876

Attachment 80052: new patch that clears page between tests.
https://bugs.webkit.org/attachment.cgi?id=80052&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
It looks like the mac port actual loads the HTML string <html></html> with the
URL about:blank.  Does it matter?  The mac port also immediately calls
stopLoading().	Do we need to do that too?

The ChangeLog for Mac DRT says this is to delay onload handlers, so it doesn't
seem like Mac DRT has the same problem with GL contexts.  I suspect there is a
real chromium/v8 bug here and this is going to make it harder to fix that bug. 
However, being more consistent with the Mac DRT is a good thing, so I think
this change is worthwhile.

In the ChangeLog, please explain why this is being added to the Chromium DRT.

r- mainly for ChangeLog.