[webkit-reviews] review granted: [Bug 53050] Remove RenderSlider::inDragMode and use SliderThumbElement::inDragMode instead. : [Attachment 79989] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 25 09:06:30 PST 2011


Darin Adler <darin at apple.com> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 53050: Remove RenderSlider::inDragMode and use
SliderThumbElement::inDragMode instead.
https://bugs.webkit.org/show_bug.cgi?id=53050

Attachment 79989: Patch
https://bugs.webkit.org/attachment.cgi?id=79989&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Seems strange to have all this code that is render tree oriented have to go
back to the DOM tree for one thing and not the rest. The RenderThemeWin code
especially stands out, with all those renderer checks mixed in with one DOM
check.


More information about the webkit-reviews mailing list