[webkit-reviews] review requested: [Bug 51456] Introduce FontMetrics abstraction : [Attachment 80043] Fixup patch v2 (new approach, only SVGFonts changes)
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 25 03:35:52 PST 2011
Nikolas Zimmermann <zimmermann at kde.org> has asked for review:
Bug 51456: Introduce FontMetrics abstraction
https://bugs.webkit.org/show_bug.cgi?id=51456
Attachment 80043: Fixup patch v2 (new approach, only SVGFonts changes)
https://bugs.webkit.org/attachment.cgi?id=80043&action=review
------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Another attempt, which does not involve changing the lroundf() rounding for
lineSpacing, I'm worried about the number of rebaselines, that would need
discussion first, as it changes the visual appearance of lots of tests.
I'll try again with just fixing SVGFonts alone, let ossy try on Qt/64 and see
if it helps :-)
More information about the webkit-reviews
mailing list