[webkit-reviews] review requested: [Bug 52983] Eliminate m_tagHistory pointer from CSSSelector : [Attachment 80009] better CSSParserSelector, more OwnPtrs

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 24 20:05:54 PST 2011


Antti Koivisto <koivisto at iki.fi> has asked  for review:
Bug 52983: Eliminate m_tagHistory pointer from CSSSelector
https://bugs.webkit.org/show_bug.cgi?id=52983

Attachment 80009: better CSSParserSelector, more OwnPtrs
https://bugs.webkit.org/attachment.cgi?id=80009&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
Implemented most of Darin's comments and updated to current trunk. Nasty
casting trick in CSSSelector::value() is still there as trying to switch the
interface to return AtomicStringImpl* resulted in a ballooning refactoring.

Requesting re-review due to significant changes.


More information about the webkit-reviews mailing list