[webkit-reviews] review granted: [Bug 53058] Reset the page scale factor on standard frame loads : [Attachment 80005] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 24 18:30:02 PST 2011


mitz at webkit.org has granted Anders Carlsson <andersca at apple.com>'s request for
review:
Bug 53058: Reset the page scale factor on standard frame loads
https://bugs.webkit.org/show_bug.cgi?id=53058

Attachment 80005: Patch
https://bugs.webkit.org/attachment.cgi?id=80005&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=80005&action=review

> Source/WebKit2/UIProcess/WebPageProxy.h:263
> +    void viewScaleFactorDidChange(double scaleFactor);

Can omit “scaleFactor”

> Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:438
> +	   newPageScaleFactor = 1.0;

Should omit “.0”. Also, no need to fetch the value if the above condition
holds, only to have it overwritten by 1.


More information about the webkit-reviews mailing list